Repository navigation
support flopy3's period-data attribute names - #541
Merged
Merged
Conversation
A Legacy keyword was only taken by constructors, so assigning wel.stress_period_data silently did nothing and reading it raised. Each one is now an attribute too, with the same warning, reading and assigning period_data. By name only: the value is flopy4's, not an MFTransientList. STO's and OC's keywords are converted, so they have no value of their own. Their attributes raise, pointing at period_data. Co-Authored-By: Claude Opus 5.5 <[email protected]>
wpbonelli
marked this pull request as ready for review
November 5, 2026 19:12
wpbonelli
added a commit
to wpbonelli/pyphoenix-project
that referenced
this pull request
Nov 6, 2026
Not started. get_data, set_data, .array and .data on PeriodRows, if unchanged 3.x scripts become a goal, since modflowpy#541 only covers the names. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the legacy aliases only worked for init, so assigning e.g.
wel.stress_period_datasilently did nothing and reading it raised. Support attribute access/assignment too, with the same warning as init